search

bufferapp / buffer-extension-shared

Shared code between Buffer extensions
MIT License
21 stars 13 forks source link

Fix image scraper #41

Closed smurfpandey closed 8 years ago

smurfpandey commented 10 years ago

For some pages instead of image URL, the actual URL of page was getting picked up

URL: On https://code.facebook.com/posts/454616284650560/building-a-faster-messenger/ Browser: Firefox 30.0a2

djfarrelly commented 10 years ago

Hey @smurfpandey, I don't believe the page scraper is being used in the extension anymore. Currently our page scraping is happening on Buffer's backend. We may plan to resurrect some client side scraping in the extension in the future, so I'm going to leave this PR active. Thanks for the help!

smurfpandey commented 10 years ago

@djfarrelly I am interested in knowing why you guys decided to move it to backend, I think doing it on client side will be much faster compared to backend. Would like to hear your thoughts on this.

djfarrelly commented 10 years ago

@smurfpandey, I'm not 100% sure why that move was made, but having it on the server has the advantage that we can roll out fixes faster and have all of our scraping logic work exactly the same in the extension and other apps. In the future, we may explore moving back to this if we have the time to write test cases and have full parity with our server side scraper. Thanks for your help and input! :+1: