bufferapp / buffer-ios-image-viewer

The BFRImageViewer is a turnkey solution to present images within your iOS app 🎉!
MIT License
398 stars 55 forks source link

Fix #83: Don't ever display status bar if presenting view controller didn't. #84

Closed chrisvasselli closed 5 years ago

chrisvasselli commented 5 years ago

Without this fix, the status bar would briefly be presented (and then immediately dismissed) during the transition animation to display an image. More importantly, this would cause the y-position of the original image to be off by the height of the status bar during the transition animation, causing a distracting jump.

The fix is to never request the status bar to be displayed, if the presenting view controller was not presenting a status bar.

Fixed version of the GIF from the issue: fixed

DreamingInBinary commented 5 years ago

Awesome - thanks @clindsay 👍