Implement new library to retrieve static assets URL

bufferapp / buffer-js-static-assets

MIT License

0 stars 0 forks source link

Implement new library to retrieve static assets URL #1

Closed philippemiguet closed 5 years ago

philippemiguet commented 5 years ago

This is ready for review. It is being used in this PR: https://github.com/bufferapp/buffer-login/pull/47.

This first version will work well for SSR. I was thinking we could work on a client-side React version during the next hack-week :)

esclapes commented 5 years ago

@djfarrelly wondering if we want to wait for Phil to move forward with this one. I am happy to work on this if necesary.

@ssvmvss is this blocking for you?

djfarrelly commented 5 years ago

@esclapes, I think we'll need to make some sort of change either in this code or in https://github.com/bufferapp/buffer-login/pull/47 to fix the potential race condition that could happen when loading static assets.

I'm also happy to dig into these changes. I don't think it will take me too long and I know you have a lot on your plate with the migration script!

djfarrelly commented 5 years ago

I just pushed a synchronous version of the same function to avoid potential race conditions in the short term!