hamstu
commented
5 years ago Thanks for the great review here @djfarrelly. 🤗
In answer to almost all of your questions above: I thought about this some more on Friday and realized that we don't need to do anything special with *.map files as long as we configure webpack to add a hash before upload. This is pretty easy to do with a small addition to the source map configuration (see here).
There are a few reasons I like this approach:
- It doesn't require changes to
buffer-static-upload - It's done during (webpack) build time, meaning it adds the correctly hashed
sourceMappingURLto the bottom of the bundles (on the flipside, if we were to add versioning to .map files on the static uploader side, it would have to modify the bundled JS file to point to the updated path) - It works well for caching / storage on S3 - same as the other static files
With all that in mind, I'm going to close this PR, since I can now go back to using 0.2.1 with no issues.
As a tiny side note, in line with your SemVer message to the team, my gut would think this would be a 0.3.0 release when we publish it as stable. In a post-1.0 world I think this would mean a major breaking change which would push it a major version bump 😄
This is really helpful feedback, thanks! I didn't think too much about the version number in my haste to have something available, but in retrospect I agree it would have merited a bigger bump. I'll be sure to pause next time and give a little more consideration to that. 🙏
See https://github.com/bufferapp/buffer-publish/pull/462 for context.