bufferapp / buffer-static-upload

📁→☁️🤘 Making it easy to upload your static assets
MIT License
4 stars 4 forks source link

Fix: Too many open files while uploading static assets #22

Closed peter-emil closed 3 years ago

peter-emil commented 3 years ago

moved file.close() to the end of the loop as opposed to deferring the call. This is because deferring the call would close all the files after the function scope is finished which results in an accumelated number of open files. This causes the utility to crash when too many files are being uploaded all at once.

peter-emil commented 3 years ago

@msanroman Hey Mike, I'm not sure which Jenkins issues are you referring to since we ran into a bunch of them last week. For this issue, we spotted it in the buffer-marketing pipeline.

Here is a link to the original message (see thread for full details) https://buffer.slack.com/archives/C0H8K9H8F/p1634592205204500?thread_ts=1633537895.170500&cid=C0H8K9H8F