search

bufferapp / clean-architecture-components-boilerplate

A fork of our clean architecture boilerplate, this time using the Android Architecture Components
MIT License
1.28k stars 178 forks source link

BrowseBufferoosViewModelFactory doesn't support multiple ViewModel subclasses #4

Open vlazzle opened 7 years ago

vlazzle commented 7 years ago

This is probably not a big deal right now since there's currently just one ViewModel subclass, but it's still worth noting...

Right now BrowseBufferoosViewModelFactory only supports one ViewModel subclass--BrowseBufferoosViewModel. If you define a second subclass of ViewModel, calling ViewModelProviders.of(this, viewModelFactory).get(SecondViewModel::class.java) will throw IllegalArgumentException: Unknown ViewModel class.

One way to address this is to have BrowseBufferoosViewModelFactory fetch a Provider<ViewModel> from the multibound map using modelClass as the key. Further details.

hitherejoe commented 7 years ago

Nice! :) Yea I planned on adding something to support this at some point this week - that looks like a good way of doing so

RowlandOti commented 5 years ago

Hi, @hitherejoe this is not an issue but just curiosity. Kindly, could you please let me know what tool was used to create the flow charts below:

architecture