search

bufferapp / clean-architecture-koin-boilerplate

A fork of our clean architecture boilerplate, this time using Koin
MIT License
331 stars 52 forks source link

Dependency update and migration to AndroidX #9

Open xmellado opened 5 years ago

xmellado commented 5 years ago

Hello,

I will use your template for a new project at work and we have decided to update its dependencies. I have updated all library versions and migrate everything to AndroidX, including tests. There is a changelog file with all the changes and I have added a plugin for checking dependency updates.

I hope you find it useful, Xavi

LukasAnda commented 5 years ago

Very good migration but I am unable to execute instrumental tests

xmellado commented 5 years ago

Hi, @LukasAnda I have "fixed" instrumentation tests. There were two problems: 1) The compilation issue was introduced by Mockito Android 2.23.x, which is not compatible with current Android Gradle Plugin. When a new version of the Android Gradle Plugin becomes available, this dependency can be updated. 2) Koin 1.0.2 makes the browser activity test fail, since the mocked BufferooRepository does not work properly. So I downgraded the version to 1.0.1 and it works fine. If you or anyone reading this thread can help me with this issue, I will appreciate it.

Thanks for pointing this problem, Xavi

LukasAnda commented 5 years ago

Hi @xmellado thanks for response :) I've been trying to solve it by myself, and I submitted an issue to Koin team. Here you can view the issue https://github.com/InsertKoinIO/koin/issues/326

xmellado commented 5 years ago

Hi, @LukasAnda I have updated Koin to version 2.0 and I have fixed the instrumental tests ;) Regards, Xavi