search

bufferapp / diggdigg

DiggDigg is the floating all-in-one share bar for your WordPress website.
http://bufferapp.com/diggdigg
GNU General Public License v3.0
32 stars 34 forks source link

PHP7 class constructors #65

Open garthreckers opened 7 years ago

garthreckers commented 7 years ago

All of the classes in dd-class.php use the old style constructor (name of class as function). Can these get updated to use __construct instead for future releases? Would hate to have to update that file manually each time there is a new version.

aronmarriott-smith commented 7 years ago

Hi @garthreckers, I agree with you on updating the class constructors to use __construct rather than the old PHP4 way. I have started work on a feature branch with Travis IC unit testing so we can see the deprecated errors in PHP7: https://travis-ci.org/aronmarriott-smith/diggdigg/jobs/180271282 As you probably already know there are a lot of deprecated warnings generated!

It may be a good idea to create a pull request with the changes you made to resolve the issue, then hopefully @katzien can merge it in and update the plugin on wordpress.org?