search

bufferapp / php-bufflog

php logger for all PHP Buffer services
1 stars 1 forks source link

"Type safety" #21

Closed erickhun closed 4 years ago

erickhun commented 4 years ago

We got few incidents when passing the wrong type of parameters. Since it makes the PHP erroring out and make a full service stop, I simply output an error message instead of stopping the script execution.

I was thinking to use the type-hint but since we use the magic function call_user_func_array i'm not too sure how to do it altogether.

@colinscape up for a review?

erickhun commented 4 years ago

@colinscape fantastic idea, I like it. and with that we could also monitor how engineers don't use the library correctly . I'va made your changes suggested with https://github.com/bufferapp/php-bufflog/pull/21/commits/9678047c72999593991d4329bf304bdf8547a268 . Added the ["bufflog_error" => "XXXX"] fields, so we could follow how and how often the library being missused