Fix Background Image Handling and Implement Dark Mode Exclusion

[smilepant]

This pull request introduces key enhancements and bug fixes to the dark mode conversion functionality, specifically targeting the handling of background images. The changes aim to improve the user experience and flexibility of dark mode customization. Below are the detailed updates included in this pull request:

Changes Made:

• Fixed Background Image Conversion: Addressed an issue where background images were not correctly optimized for dark mode. Adding class nightowl-bg-image ensures that background images seamlessly integrate with the dark theme, enhancing visual consistency across the application.
• Added Dark Mode Exclusion Class: Introduced a new class nightowl-exclude-dark that can be applied to elements with background images intended to be excluded from dark mode conversion. This feature provides users with greater control over the appearance of their content in dark mode, allowing for specific components to remain unchanged for design or readability reasons.

[Onatcer]

How is this different from .nightowl-daylight ?

[smilepant]

How is this different from .nightowl-daylight ?

The usage of the nightowl-daylight class within our project, although not currently documented in the README, raises some questions regarding its purpose and implementation. This oversight suggests a need for better documentation to ensure clarity for all project contributors. Additionally, the name nightowl-daylight may lead to confusion due to its lack of immediate clarity. A more descriptive class name, such as nightowl-exclude-dark, could be more intuitive, directly indicating its role in excluding dark mode styling from certain elements.

For future-proofing the project, it's renaming the class for better readability and including detailed documentation on its purpose and usage. This documentation should ideally be added to the README file, alongside examples demonstrating the class's effect within the project. This approach will facilitate easier updates and enhancements to the project, promoting a more intuitive and maintainable codebase.

[Onatcer]

I'd accept merge requests to improve the documentation and I'm also open to discuss the naming.

But I'm not discussing with ChatGPT.

[smilepant]

I'd accept merge requests to improve the documentation and I'm also open to discuss the naming.

But I'm not discussing with ChatGPT.

haha I used chat GPT to improve my writing

[smilepant]

I'd accept merge requests to improve the documentation and I'm also open to discuss the naming. But I'm not discussing with ChatGPT.

haha I used chat GPT to improve my writing

nightowl-exclude-dark looks quite similar but nightowl-daylight class is not even mentioned in the readme, to extend this project for the future nightowl-daylight sounds confusing while nightowl-exclude-dark gives a straight meaning and how does the given class work

There is no feature in CSS to directly select all background-image, so for user convenience, I added the nightowl-bg-image class which is same as nightowl-exclude-dark or nightowl-daylight but different class name.

[Onatcer]

I'm closing this as I don't see a need to add two more classes that do the same thing as a class that has already been implemented, especially the background image one seems just completely unnecessary.

[smilepant]

I'm closing this as I don't see a need to add two more classes that do the same thing as a class that has already been implemented, especially the background image one seems just completely unnecessary.

thank you