bufferoverflow / verdaccio-gitlab

private npm registry (Verdaccio) using gitlab-ce as authentication and authorization provider
MIT License
160 stars 55 forks source link

refactor: docker build improvements #31

Closed dlouzan closed 6 years ago

dlouzan commented 6 years ago

make docker build build the package locally instead of depending on the npm registry published version

bufferoverflow commented 6 years ago

great work, what about dumb-init is it worth to use?

dlouzan commented 6 years ago

@bufferoverflow I find that using an init process in a docker container is a good practice to avoid any issues with signal handling. Even if we currently just start a node process, it helps with future-proofing in case we modify the startup to handle more than one process.

There's a couple of alternatives in this field:

To make things a bit better right now, I'm pushing in a minute a change to this PR that actually installs dumb-init as checksummed apk, instead of downloading an executable from github. I guess that a the time this was written in verdaccio, there was still no ported apk package.

bufferoverflow commented 6 years ago

Very nice!