refactor(dockerfile): builder multistage pattern & random uid user support

bufferoverflow / verdaccio-gitlab

private npm registry (Verdaccio) using gitlab-ce as authentication and authorization provider

MIT License

160 stars 55 forks source link

refactor(dockerfile): builder multistage pattern & random uid user support #35

Closed dlouzan closed 6 years ago

dlouzan commented 6 years ago

build image based on current upstream verdaccio refactor, only building the plugin code and then symlinking the plugin code
randomized uid support (e.g. openshift)
plugin install directory is read-only

dlouzan commented 6 years ago

Please note: this build depends on the work being done in verdaccio under https://github.com/verdaccio/verdaccio/pull/864, in order to build this, it's needed to create a manual build of that verdaccio's PR and manually tag it:

# In verdaccio PR #864
cd ..
yarn build:docker
docker tag verdaccio:latest verdaccio/verdaccio:3.3

# Now build this image
cd ...
yarn build:docker
# available as verdaccio-gitlab:latest

dlouzan commented 6 years ago

I'm changing this to make it depend on verdaccio/verdaccio:4.x-next. But until the changes in the pending PR in verdaccio for refactored dockerfile are applied, this won't work unless we build manually locally (see comment above)

juanpicado commented 6 years ago

It's out

docker pull verdaccio/verdaccio:4.x-next

bufferoverflow commented 6 years ago

This is great!

Please seperate the fixes for gitlab.js and package.json into a dedicated PR as they are not related to the docker build.