feat: gitlab-11.2-group-api-improvements

bufferoverflow / verdaccio-gitlab

private npm registry (Verdaccio) using gitlab-ce as authentication and authorization provider

MIT License

160 stars 55 forks source link

feat: gitlab-11.2-group-api-improvements #39

Closed dlouzan closed 6 years ago

dlouzan commented 6 years ago

use the new gitlab 11.2 min_access_level parameter in the groups api: publish rights are now configurable based on the access level of the user to the groups, it doesn't require owner permissions
add new configuration parameters for access and publish access levels

Fixes #5

bufferoverflow commented 6 years ago

Great! I guess we need the following before we merge:

compatible with <11.2 (via API call or legacy_mode: true for old versions < 11.2)
remove access cache, so just one instead of two api calls to gitlab
create a upstream issue for access and publish group

dlouzan commented 6 years ago

Quick question: if we are going to add the legacy flag in the configuration, which will be disabled by default, I guess we can also set the default publish access level to $maintainer? At least it feels more natural to me. When legacy_mode: true, the value applied will be $owner anyway, there's no other option pre-11.2.

bufferoverflow commented 6 years ago

Good idea @dlouzan , fully agree!

dlouzan commented 6 years ago

Just pushed the latest changes:

remove access access level configuration parameter since it cannot be used with the current plugins api
support gitlab 9.0+ with a new legacy_mode configuration flag; when not in legacy mode, gitlab 11.2+ is required
improved README, document all configuration options

dlouzan commented 6 years ago

Done, I'm adding commits on top of the original PR commit. Feel free to squash when accepting.

bufferoverflow commented 6 years ago

Great work!