bufferoverflow / verdaccio-gitlab

private npm registry (Verdaccio) using gitlab-ce as authentication and authorization provider
MIT License
160 stars 55 forks source link

feat: add project groups #62

Closed jstarry closed 5 years ago

jstarry commented 5 years ago

References: https://github.com/bufferoverflow/verdaccio-gitlab/issues/63

If a Gitlab user is a maintainer of a project but not a maintainer of the group that the project is in, they should still have publish rights.

jstarry commented 5 years ago

@dlouzan would you mind looking over this PR? Thanks 👍

jstarry commented 5 years ago

Cool! Thank you @bufferoverflow for creating this plugin, it's just what we needed 👍

bufferoverflow commented 5 years ago

@dlouzan Could you review this as well and merge if you agree on it?

dlouzan commented 5 years ago

This is a great PR, I'm currently checking the code but it really looks fantastic

dlouzan commented 5 years ago

This makes perfect sense. The use of two Gitlab API calls should be completely ok under high load by using the cache.

Your code is actually much more elegant and I love how you used Promise.all and the spread operator to join the results.

LGTM :+1: