search

bufferoverflow / verdaccio-gitlab

private npm registry (Verdaccio) using gitlab-ce as authentication and authorization provider
MIT License
160 stars 55 forks source link

Questions before contributing #65

Closed blackholegalaxy closed 4 years ago

blackholegalaxy commented 5 years ago

I'd like to add some features on this package, but I have some questions before contributing.

  1. Could you explain why we initialize a global tunnel in src/verdaccio.js?
  1. I see despite the fact we use verdaccio 3.x in package.json dependencies, we build docker image using 4.x-next base verdaccio docker image. Could this cause instability because we build a plugin for an older version of verdaccio than the one used in the base docker image?
dlouzan commented 5 years ago

Hello, thanks for participating in the project!

  1. The global tunnel is used for compatibility with corporate environments, where internal proxies are used. With no explicit configuration, it will use the http(s)_proxy variables from the environment (see the official docs).
  2. The docker image is built based on 4.x because there's heavy refactoring of the docker image in verdaccio 4.x and we built on top of it. @juanpicado has promised to keep 4.x quite stable and shouldn't be long for a release (or so I hope :-)
dlouzan commented 5 years ago

Sorry I didn't fully answer your plugins question: yes, that might be the case. Although as of today we hadn't found any issues, it could happen. I'll open an issue to track this.

juanpicado commented 5 years ago

has promised to keep 4.x quite stable and shouldn't be long for a release (or so I hope :-)

My soul was just sold 😆 . Yes, hopefully we finish the UI along February and couple of things and we can launch a beta with no further additions for a month. Then, big release.

blackholegalaxy commented 5 years ago

Thanks for explainations! In the meantime, I will try to build a Docker image on top of 3.x version, because my company is always afraid of potential incompatibilities. Will watch for v4 and will try to add my planned features on v4.x.

bufferoverflow commented 4 years ago

closing this as we are on 4 now