bufferoverflow / verdaccio-gitlab

private npm registry (Verdaccio) using gitlab-ce as authentication and authorization provider
MIT License
160 stars 55 forks source link

Plans to separate plugin behavior from full Verdaccio installation? #67

Closed mark-schaal closed 5 years ago

mark-schaal commented 5 years ago

Appreciate your work here, a quick general question:

Based on your docker-compose.yml files and Dockerfile, it seems that this repository is primarily targeted at creating the full stack of services (GitLab, Verdaccio, GitLab Auth Plugin).

Do you have any plans to separate/isolate the plugin specific installation functionality at any point, or would it be better practices for consumers to implement a solution similar to the Dockerfile in verdaccio-ldap where yarn installs the package from npm during their custom image build process?

dlouzan commented 5 years ago

Hello @mark-schaal, @bufferoverflow is on leave and probably will not answer until March.

I'm not sure I fully understand the question. The Dockerfile will only install verdaccio-gitlab on top of the verdaccio 4.x image. And the npm package is also available, so if you want to use the same approach as verdaccio-ldap, it's just another very simple Dockerfile on your end.

The docker-compose file is basically a sample on how to use the whole system, plus we also use it for testing (but you can run just verdaccio from that file without starting gitlab).

You can also take a look at the helm chart for a more complex scenario (we've actually used it running in OpenShift):\ https://github.com/helm/charts/tree/master/stable/verdaccio

What is exactly you want to achieve, or what is your use case?

dlouzan commented 5 years ago

Closing due to inactivity