meson.build: check git exit status

[ghost]

~~The default value for this argument will change in a future meson release. This commit silences the warning and keeps the old behavior.~~

The default value for the check argument on run_command will soon change from false to true. Set it explicitly to false in order to silence the warning, and check the exit status ourselves for a nicer error message.

[eli-schwartz]

This commit silences the warning and keeps the old behavior.

Why do you want the old behavior? If the git commands error out and the version cannot be determined, shouldn't this be a fatal error? In such a case, the user is supposed to specify -Dkiwmi-version=.

[ghost]

Why do you want the old behavior? If the git commands error out and the version cannot be determined, shouldn't this be a fatal error? In such a case, the user is supposed to specify -Dkiwmi-version=.

I just did what i saw elsewhere, but didn’t look closely enough to notice they check it manually. Gonna fix, thanks!

[buffet]

Yeah, I feel like failing is the better approach here.

[eli-schwartz]

Yep, that's why Meson made the change to a warning. :D

[buffet]

Thanks!