Qazzquimby
commented
5 years ago I don't have a lot of experience with Github collaboration. Please let me know if there's anything I should do differently.
Closed Qazzquimby closed 5 years ago
Qazzquimby
commented
5 years ago I don't have a lot of experience with Github collaboration. Please let me know if there's anything I should do differently.
buffet
commented
5 years ago Thanks! For not having a lot of collaboration experience you're doing excellent.
Qazzquimby
commented
5 years ago Changes made. I'm thinking your comments in issue #4 should be worked into the readme. Should I do that?
buffet
commented
5 years ago Actually, yeah. The readme is currently missing a lot of information that's spread over http://blog.countingsort.com and #4.
If you would add it here it would be really nice.
"it adds a lot of" -> "they add significant". Subject is plural.
"kiwmi" -> "Kiwmi" at beginning of sentence.
". Much like how bspwm works" -> ", similarly to how bspwm works". Merge fragment sentence.
"On top of that, kiwmi barely handles anything on it's own. Instead it emmits events, to which the client can subscribe and react accordingly." -> "Kiwmi handles barely anything on it's own, and instead it emits events, to which the client can subscribe and react accordingly." Remove unnecessary transition for concision. Fix "emmits" to "emits". Merge sentence fragment.
"As soon as they exist I'll link a few user configurations, that are likely to help you get started." -> "New user configurations will be linked as they are created, to help new users get started." Move subject to beginning of sentence. Remove "I" as actor for formality and in case of collaboration.
"This means the user will end up using a big, monolithic frontend, or a collection of small scripts, to configure kiwmi. -> "Kiwmi will end up being configured by a monolithic frontend, or collection of small scripts." Move main subject to beginning of sentence. Remove "big" from monolithic. "End up" could also be reworded.
"If I get around to it I will probably create a small Python (probably) library, to make it easier to create a monolithic frontend." -> "A small (probably) Python library may be created to aid creating a monolithic frontend." - Move main subject to beginning. Remove "I" actor. "To make it easier to create" -> "aid creating."
Fixes #6