search

bufgix / passwall-extension-old

Browser extension for PassWall
GNU Affero General Public License v3.0
29 stars 1 forks source link

Use antd for ui #1

Open yasintz opened 4 years ago

yasintz commented 4 years ago

Instead of uikit, antd used on the web and desktop should be used.

yakuter commented 4 years ago

I agree. We must use almost same technologies in all clients. @bufgix, beacuse you are the author of this repo, asking you first. Do you want to work on this?

bufgix commented 4 years ago

My purpose is to keep the plugin size minimum. That's why I use UIKit. But if you want to change, we can switch to antd

yakuter commented 4 years ago

Is antd so big in size? I heard that is is fast.

bufgix commented 4 years ago

resim

Also, we use vue bundle of antd size may be bigger

mtoygar commented 4 years ago

Bundle size may not be an issue for an extension. I couldn't find a document reference for this but as far as I understand extensions store its resources locally. On my Mac extension sources stored in the below directory. HOME_DIRECTORY/Library/Application Support/Google/Chrome/Default/Extensions/EXTENSION_ID

Since there is no network request to download resources, bundle size might be neglected.

a similar opinion from stackoverflow. https://stackoverflow.com/a/12963902