fixes #76, warning: pointer of type ‘void *’ used in arithmetic

bugaevc / wl-clipboard

Command-line copy/paste utilities for Wayland

GNU General Public License v3.0

1.62k stars 59 forks source link

fixes #76, warning: pointer of type ‘void *’ used in arithmetic #80

Closed lcandeago closed 4 years ago

lcandeago commented 4 years ago

fixes #76, warning: pointer of type ‘void *’ used in arithmetic

bugaevc commented 4 years ago

Hi, and thanks!

Please change the commit message to be more in line with other commit messages in the project. For example,

Fix a warning

We should not be using void * in pointer arithmetics.

Fixes https://github.com/bugaevc/wl-clipboard/issues/76

(Make sure the commit message contains the complete URL of the issue, even though GitHub is only going to display it as #76.)

Then notice that offer->offered_mime_types was nicely aligned on the two lines. So maybe indent the next line further to keep the alignment?

lcandeago commented 4 years ago

Should be fixed now. I don't know why github doesn't show the right indentation, but locally, I've checked with various text editor and the "offer" are alligned.

bugaevc commented 4 years ago

I don't know why github doesn't show the right indentation, but locally, I've checked with various text editor and the "offer" are alligned.

It's because you've got a tab character there. Please format using spaces instead.

Also:

It should be const char *, not mutable char *
There should be a space between the (const char *) and the next expression.

lcandeago commented 4 years ago

Should be fixed now! Thanks for your patience!

bugaevc commented 4 years ago

Thank you! :smile: