search

bugcrowd / double_red

API for collecting Double Red color sensor readings (Winter 2017 hackathon)
7 stars 4 forks source link

Remove and rotate secret_key_base from repo when we care about sessions #5

Closed dradford closed 7 years ago

dradford commented 7 years ago

https://github.com/bugcrowd/double_red/blob/2939c733b2bcea53697e899f6322cd64f434dd92/config/config.exs#L15

paulfri commented 7 years ago

Not necessary -- that config is overridden by the prod-specific config which specifies to pull the SECRET_KEY_BASE from the system environment. (https://github.com/bugcrowd/double_red/blob/5fc42afb3045bc753e5a88d213aaaf9f971cf5f8/config/prod.exs#L8). That secret is fine for dev/test sessions.