search

bugcrowd / test-summary-buildkite-plugin

Buildkite plugin to summarise all test failures as an annotation
MIT License
68 stars 39 forks source link

Checkstyle formatter not tolerant to optional attributes #51

Closed maschwenk closed 5 years ago

maschwenk commented 5 years ago

Checkstyle formatter should be more tolerant to missing attributes on <error>. For example:

<error severity="error" message="Needless blank line(s)" source="no-consecutive-blank-lines" />
<error line="106" column="1" severity="error" message="Needless blank line(s)" source="no-consecutive-blank-lines" />

line and column appear to be optional.

I can't really find a formal definition for Checkstyle but it seems these attributes are not always required, so the formatter should be tolerant of that (while not necessarily laying out the red carpet for it)