search

bugen / pypipe

Python pipe command line tool
Apache License 2.0
796 stars 25 forks source link

Failed to release v.0.4.0 #32

Closed bugen closed 11 months ago

bugen commented 11 months ago

The release of v0.4.0 has failed. https://github.com/bugen/pypipe/actions/runs/7182600141

bugen commented 11 months ago

Until version 1.18.0, hatch did not raise an error when there were no files matching the default file selection, as it automatically included *.py in such cases. However, starting from v1.19.0, an error occurs if there are no files matching the default file selection unless we explicitly specify the files to include in the wheel.

For information about the default file selection:

I confirmed that the build passes by adding the following settings to pyproject.toml:

[tool.hatch.build.targets.wheel]
packages = ["pypipe.py"]
bugen commented 11 months ago

@diazona Could you review the changes?

I confirmed that the build passes by adding the following settings to pyproject.toml:

[tool.hatch.build.targets.wheel]
packages = ["pypipe.py"]

Is it okay with just this change? If there are any additional modifications needed, could you please send a pull request?

diazona commented 11 months ago

Sure, I'll take a look at this when I have time, later today or tomorrow, if that's okay. I'll comment again here.

diazona commented 11 months ago

I checked over the documentation of hatch, and I believe you're right that this is the only change necessary. :+1:

Or, another alternative would be to restrict the version of hatchling used to build this project to 1.18 or earlier. But that wouldn't be as good of a solution, for obvious reasons. (I just mentioned it so you know such a thing would be possible)

bugen commented 11 months ago

@diazona Thank you for the review.

Or, another alternative would be to restrict the version of hatchling used to build this project to 1.18 or earlier. But that wouldn't be as good of a solution, for obvious reasons

I also don't think it's a good idea to restrict the version unless there are special reasons. I will apply the fixes and proceed with the release.