Closed DimaGolomozy closed 1 year ago
That's for sure interesting! However you made some of really useful packages internal, and if we talking about writing some "go plugins" in future, having byteutils
or proto
packages accessible as import can be very benificial.
That's for sure interesting! However you made some of really useful packages internal, and if we talking about writing some "go plugins" in future, having
byteutils
orproto
packages accessible as import can be very benificial.
I guess the proto
can go out of internal.
About byteutils
, isn't more internal helpers to do stuff on bytes? Do you really want to expose it?
I see, makes sense. If in future it will be needed, most likely it will be needed indirectly by exposing more human friendly interface. in this case lets make "proto" package open, and we can merge.
I see, makes sense. If in future it will be needed, most likely it will be needed indirectly by exposing more human friendly interface. in this case lets make "proto" package open, and we can merge.
done
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
21 Code Smells
No Coverage information
0.7% Duplication
Looks good!
change package from
main -> goreplay
this will allow importinggoreplay
as a package@buger wdyt?