search

buger / goreplay

GoReplay is an open-source tool for capturing and replaying live HTTP traffic into a test environment in order to continuously test your system with real data. It can be used to increase confidence in code deployments, configuration changes and infrastructure changes.
https://goreplay.org
Other
18.53k stars 13 forks source link

goreplay-cli package #1148

Closed DimaGolomozy closed 1 year ago

DimaGolomozy commented 1 year ago

change package from main -> goreplay this will allow importing goreplay as a package

@buger wdyt?

buger commented 1 year ago

That's for sure interesting! However you made some of really useful packages internal, and if we talking about writing some "go plugins" in future, having byteutils or proto packages accessible as import can be very benificial.

DimaGolomozy commented 1 year ago

That's for sure interesting! However you made some of really useful packages internal, and if we talking about writing some "go plugins" in future, having byteutils or proto packages accessible as import can be very benificial.

I guess the proto can go out of internal. About byteutils, isn't more internal helpers to do stuff on bytes? Do you really want to expose it?

buger commented 1 year ago

I see, makes sense. If in future it will be needed, most likely it will be needed indirectly by exposing more human friendly interface. in this case lets make "proto" package open, and we can merge.

DimaGolomozy commented 1 year ago

I see, makes sense. If in future it will be needed, most likely it will be needed indirectly by exposing more human friendly interface. in this case lets make "proto" package open, and we can merge.

done

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

buger commented 1 year ago

Looks good!