buger / goreplay

GoReplay is an open-source tool for capturing and replaying live HTTP traffic into a test environment in order to continuously test your system with real data. It can be used to increase confidence in code deployments, configuration changes and infrastructure changes.
https://goreplay.org
Other
18.42k stars 4 forks source link

feat: fix bug that len(last payloads) is less than 5 #1226

Open HarryWang29 opened 9 months ago

HarryWang29 commented 9 months ago

I got a special pcap, the last packet of http resp is just '0x0a' then I found a bug in HasFullPayload

a portion of data from the pcap file 4.zip

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

ghost commented 9 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/buger/goreplay/1226/4372fe4a/3888fad41c2523264677d3a449994525b6bc78f5.svg)](https://app.codesee.io/r/reviews?pr=1226&src=https%3A%2F%2Fgithub.com%2Fbuger%2Fgoreplay) #### Legend CodeSee Map legend
sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information