search

bugfest / tor-controller

Tor toolkit for Kubernetes (Tor instances, onion services and more)
Apache License 2.0
98 stars 17 forks source link

[BUG] Container releases not following GitHub releases #53

Closed codekow closed 10 months ago

codekow commented 1 year ago

Describe the bug New container image tags are not available in quay for releases after 0.9.0

To Reproduce See:

Expected behavior Expect to see container image tags updated for each release

bugfest commented 1 year ago

Hi @codekow, the latest container images are tagged as 0.9.0, tor-controller releases are in reality the helm chart version; latest version is 0.1.11. Full version table is documented at https://github.com/bugfest/tor-controller#versions

Please let me know if I this answer your case.

codekow commented 1 year ago

Maybe I'm seeing another issue or I don't understand the release cycle.

I would assume each container image is versioned with the release version in the repo.

There are 4 Dockerfile(s) in this repo:

I would expect the tags in quay to match the release since the release may have changed the container image. I'm not seeing those tags.

codekow commented 1 year ago

I would avoid tagging container images based on the helm version. Container image tags should typically align with code releases building them.

That can be very confusing otherwise.

bugfest commented 1 year ago

Hi @codekow,

We're not using image tags to tag the helm version; they're following different version numbers. All the containers are tagged based on the functionallities we're releasing; probably you're confussed due to the fact that we're using 2 tag formats in parallel.

This project builds 2 artifact types: containers and a helm chart. The later is hosted in gh pages. To achieve it we use two tag formats (https://github.com/bugfest/tor-controller/tags):

Hope this clarifies it.