search

buggedcom / phpvideotoolkit-v2

PHP Video Toolkit version 2 helps take the voodoo out of ffmpeg and provides a convenient object oriented wrapper around the ffmpeg programme.
Other
260 stars 86 forks source link

php syntax warning #114

Open ryangroth5 opened 5 years ago

ryangroth5 commented 5 years ago

getting a syntax error with PHP 7.3.2, "continue is the same as break in a swtich" the following patch suppresses the error and will work for any version of PHP: 

--- a/src/PHPVideoToolkit/Mime.php~ 2019-02-06 20:11:38.000000000 +0000
+++ b/src/PHPVideoToolkit/Mime.php  2019-03-01 15:57:29.245315100 +0000
@@ -186,7 +186,7 @@

                          default:
                             // date, ldate, ledate, leldate, beldate, lebelbe...
-                            continue;
+                            break;
                       }
                    }
blue-eyed-devil commented 5 years ago

have same with php 7.3.3 but only if resizing from small to larger video:

PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /var/www/vendor/buggedcom/phpvideotoolkit/src/PHPVideoToolkit/Mime.php on line 189