search

buggins / coolreader

Official site of CoolReader project. Sourceforge repository is obsolete.
GNU General Public License v2.0
387 stars 101 forks source link

tts hide toolbar #328

Open teleshoes opened 2 years ago

teleshoes commented 2 years ago

when clicking outside of the TTS toolbar, show/hide the TTS toolbar, instead of stopping TTS.

this fixes issue #320

many thanks to @plotn for the idea and implementation outline!

p.s.: the majority of this PR is whitespace/indentation. skip the first commit to see just the actual changes

plotn commented 2 years ago

@teleshoes, go back to conversations with good ideas ))

teleshoes commented 2 years ago

haha, i guess it was my idea, though you fixed it by having it toggle instead of dedicated toolbar button to hide. joint effort anyway

plotn commented 2 years ago

I mean any other good ideas, not this case.

teleshoes commented 2 years ago

yea, i PR'd just this one simple idea, for least-change to most directly resolve issue #320, with a minimum of things anyone could reasonably object to. personally, im including a few more of your ideas in my own build

edit: in case i misunderstood you yet again...i will happily continue posting any ideas where you and others can find them :D

plotn commented 2 years ago

@teleshoes , as for me it would be suitable on my discussion board: https://github.com/plotn/coolreader/discussions - you're always welcome (unfortunally "base" project has no discussion board)