Fixes #112: Migrate to std.logger (no longer experimental since DMD 2.101.0)

[vnayar]

• Removed explicit references to sharedLogger, which are now explicitly of shared type. Replaced with calls to base function, e.g. warnf, which routes to the default logger. See https://dlang.org/changelog/2.101.0.html#logger_sharedLog_returning_shared_logger
• Replaced imports of std.experimental.logger with std.logger, because std.experimental.logger has been deprecated since DMD 2.101.0.

[vnayar]

this will fail on older compilers and ddbc needs to support a range of versions. please keep the static if but amend it so that it'll work with compilers where it was still in std.experimental

I made a provisional change that I think will work, but I need to set up multiple D versions to validate locally. Looks like I need to get dvm working again on my system.

[vnayar]

this will fail on older compilers and ddbc needs to support a range of versions. please keep the static if but amend it so that it'll work with compilers where it was still in std.experimental

I made a provisional change that I think will work, but I need to set up multiple D versions to validate locally. Looks like I need to get dvm working again on my system.

Using dvm, I was able to test on DMD 2.098.1 as well as 2.097.2, and with the most recent commit, it builds and compiles correctly.

[SingingBush]

thanks for the changes. I'm not concerned about the x2 failed builds on mac as it seems macos-latest has gone from 11.7 to 12.6.2 so that'll be the reason. However the integration tests are failing because source/ddbc/pods.d still needs to be wrapped in static if the same as the other files.

in fact perhaps it's best to simply put the import at the top of the file like this:

static if(__traits(compiles, (){ import std.logger; } )) {
    import std.logger;
} else {
    import std.experimental.logger;
}

[vnayar]

Will do. I wasn't aware of those test files, but according to the build tool, I can see that build run --config=test is required to access those tests.

On Fri, Jan 6, 2023 at 7:12 PM Samael @.***> wrote:

thanks for the changes. I'm not concerned about the x2 failed builds on mac as it seems macos-latest has gone from 11.7 to 12.6.2 so that'll be the reason. However the integration tests are failing because source/ddbc/pods.d still needs to be wrapped in static if the same as the other files

— Reply to this email directly, view it on GitHub https://github.com/buggins/ddbc/pull/113#issuecomment-1373974059, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKGNHFPPEMXGKQMNPVXUITWRBOBJANCNFSM6AAAAAATTFZTVE . You are receiving this because you authored the thread.Message ID: @.***>