search

buggins / ddbc

DDBC is DB Connector for D language (similar to JDBC)
78 stars 45 forks source link

Select support uda #92

Closed shoo closed 3 years ago

shoo commented 4 years ago

The ddbc.pods are very friendly to UDA. So I let the UDA be applied to select.

As an addendum, I thought about refactoring the part of the commit that was too cluttered following this one and making UDA support for insert/update/remove as well. However, the commit was huge enough by the time I got it to support select, so I decided to split it up. If this pull request is accepted, I'll post the rest of the split in order.

After all the changes are made, it looks like this: https://github.com/shoo/ddbc/blob/c25eb0f034d6a6a03c1f1050d7fdd84677c0ab1d/source/ddbc/pods.d

SingingBush commented 3 years ago

There's good stuff in this PR, it just needs to be in the right place and be consistent with existing approach.

The pod stuff should arguably not be in ddbc or if it does, it should at least be another module. So we end up with something like:

This kind of thing is covered by Hibernated specifically in the annotations.d code with things like @Entity, @Table("table_name"), and @Column("column_name")

shoo commented 3 years ago

I see. I close this PR here. I am embarrassed to say that I only knew Hibernated by name, so I would like to learn it.

Thanks!