buggins / dlangui

Cross Platform GUI for D programming language
Boost Software License 1.0
805 stars 120 forks source link

Rewrote the decodeHexColor function #655

Closed bagomot closed 1 year ago

bagomot commented 1 year ago

Added:

All colors with transparency are still encoded in ARGB format.

GrimMaple commented 1 year ago

Can you please rebase on master?

GrimMaple commented 1 year ago

Can you please add unit tests for invalid inputs as well? It looks like this code will accept stuff like rgb(321, 321, 321).

bagomot commented 1 year ago

Can you please rebase on master?

What is meant? The code is already in the master branch.

Can you please add unit tests for invalid inputs as well? It looks like this code will accept stuff like rgb(321, 321, 321).

Ok. I will add.

GrimMaple commented 1 year ago

Why did you close the PR?

What I meant was, the PR has 2 commits (1 merge commit and 1 normal commit). I would appreciate it if you squashed & rebased on master instead, so the commit history doesn't have unnecessary commits.

bagomot commented 1 year ago

Why did you close the PR?

What I meant was, the PR has 2 commits (1 merge commit and 1 normal commit). I would appreciate it if you squashed & rebased on master instead, so the commit history doesn't have unnecessary commits.

I found errors in the function. I'll fix it and make a new PR or reopen this one.