search

buggins / dlangui

Cross Platform GUI for D programming language
Boost Software License 1.0
805 stars 120 forks source link

Question about CSS #666

Closed Yorizuka closed 1 year ago

Yorizuka commented 1 year ago

I am currently reading the dlangui source code trying to understand the code base.

I have a question about the CSS functionality, so far in all the examples and the included default styling is done via android like XML, I have not seen any CSS files in the repo. But in the source code of dlangui there is a CSS parser.

What is the state of the CSS parser? Is it an alternative syntax for ingesting the same data as the XML based styling?

GrimMaple commented 1 year ago

I'm not the original author and I don't know dlangui in and out, but I think CSS is used for DML

Yorizuka commented 1 year ago

as a test I removed:

  1. core/css.d
  2. core/cssparser.d
  3. core/dom.d
  4. dom/cssparser.d
  5. dom/encoding.d

after doing so everything seems to still work exactly the same way. So my hunch is that its unfinished & unused code.

Yorizuka commented 1 year ago

Would you be interested in or accept a PR that removes the unused code?

I can go do a more thorough test and make sure I am not about to break stuff & if it checks out remove the 5 unused files for you.

GrimMaple commented 1 year ago

PRs are more than welcome, though I'm unsure if it actually doesn't break anything. More testing would be needed. Good for us that I have a lot of dlangui projects to test on :)