search

buggregator / laravel-app

The old version of Buggregator, which uses Laravel framework, is no longer being actively developed. The new beta version, built with Spiral framework, is now available at https://github.com/buggregator/spiral-app and offers significant improvements in performance and stability, as well as a lighter docker image size of around 300mb.
https://buggregator.dev
MIT License
329 stars 24 forks source link

Using vue-ray, or js-ray etc - In browser Ray is being blocked by CORS policy #72

Closed ijpatricio closed 2 years ago

ijpatricio commented 2 years ago

CORS allowed headers are missing.

Still didn't dive into source code. Is this something you would accept a PR?

Or you see this is missing, and easy fix on your end?

image

butschster commented 2 years ago

Hi @ijpatricio.

Is this something you would accept a PR? Sure

Try to check CORS on RoadRunner side https://github.com/buggregator/app/blob/master/.rr.yaml#L12 https://roadrunner.dev/docs/http-headers

HazyAlex commented 2 years ago

Hello! I implemented these changes in #73.

Because I'm currently using the latest docker image (v1.8.4), I patched the older (i.e. non-beta) version here. Would you be willing to accept these changes and release a new version (e.g. v1.8.5) or are you just focusing on the beta and not taking requests for older versions?

butschster commented 2 years ago

Hello! I implemented these changes in #73.

Because I'm currently using the latest docker image (v1.8.4), I patched the older (i.e. non-beta) version here. Would you be willing to accept these changes and release a new version (e.g. v1.8.5) or are you just focusing on the beta and not taking requests for older versions?

Hi @HazyAlex

Thank you very much!

butschster commented 2 years ago

@HazyAlex I can't release 1.8.5 from master branch. You need to create a new PR to 1.x branch