buggyj / mediaplayer

MIT License
2 stars 1 forks source link

Preserve the timestamp when a new annotation is created #8

Open arunnbabu81 opened 2 years ago

arunnbabu81 commented 2 years ago
image

Currently if I click on the plus button to create a new annotation, a new slice gets created beneath the previous one. Now I have to click on this slice make it the active one. But the time on the youtube video comes back to the beginning of the video.

There are two solutions in my mind

  1. If a new slice is created by clicking on the plus button, let the new slice get active automatically with time of the youtube video retained at the end of the previous slice
  2. If the new slice can't be made the active slcie automatically, dont allow the time to revert to the beginning of the video on clicking the new slice link. Instead retain the time of the end of the previous slice.
arunnbabu81 commented 2 years ago

@buggyj is it doable or is there any workarounds

buggyj commented 2 years ago

I have implemented this in the new templates, which I will release soon.

arunnbabu81 commented 1 year ago

Is there any way to start playing the video from where we left in the last session ? Currently if I close the tiddler and reopen it at a latter time, the video restarts from the begining of that slice.

buggyj commented 1 year ago

I cannot think of a way of doing this automatically unless this issue in tw is fixed: https://github.com/Jermolene/TiddlyWiki5/pull/6699

arunnbabu81 commented 1 year ago

I have implemented this in the new templates, which I will release soon.

Any updates ? @buggyj

arunnbabu81 commented 1 year ago

@buggyj I saw that you have pushed some updates to the mediaplayer github repo. Is the plug in available for download? I am eager to try it out.

buggyj commented 1 year ago

It is still not ready

arunnbabu81 commented 1 year ago

It is still not ready

@buggyj any updates?

buggyj commented 1 year ago

It is still not finished - but I have put an updated demo at https://mediaplayerava.tiddlyhost.com/

arunnbabu81 commented 1 year ago

@buggyj Can I use this in my main wiki?

buggyj commented 1 year ago

I am going to do an update, this includes separating the youtube widget into it's own plugin.

The name of the templates have changed so you will need to update some of your tiddlers.

arunnbabu81 commented 1 year ago

When and from where to get that update

buggyj commented 1 year ago

it is updated here: https://mediaplayerava.tiddlyhost.com/

arunnbabu81 commented 1 year ago

Which all plug ins should I install. Is the annotation of local videos working

buggyj commented 1 year ago

the plugins are $:/plugins/bj/mediaannotations and $:/plugins/bj/mediaplayer

The $:/plugins/bj/mediaplayerAVA is no longer used.

local annotations should be working.

arunnbabu81 commented 1 year ago

Can you add a demo. I am getting this message.

image
buggyj commented 1 year ago

I have added $:/plugins/bj/ytmediaplayer to https://mediaplayerava.tiddlyhost.com/ which has this widget

arunnbabu81 commented 1 year ago

@buggyj Can you take a look at this wiki- https://scribe.tiddlyhost.com/# I am unable to get the video playing in the mediaplayer

buggyj commented 1 year ago

I will update the youtube player, it is still in a 'demo' mode, unlike the other players which are now stable.

buggyj commented 1 year ago

An new version of $:/plugins/bj/ytmediaplayer is now available.

arunnbabu81 commented 1 year ago

I dont see any change after installing the new version ? Is the tiddlyhost site updated with latest version ?

buggyj commented 1 year ago

try now

arunnbabu81 commented 1 year ago

Now the video player is seen, but the video skips to the next video without playing. Also for youtube video annotation, what is the name of the new template to be used instead of {{||$:/bj/templates/playListYTNotations}} Because of that change, annotation template is not seen. Also what is the template of local video annotation? I have uploaded a few videos in the demo wiki.

buggyj commented 1 year ago

I have now update the plugins, the plugin $:/plugins/bj/mediaplayerDynamicTmplates is also need, and now is uploaded to https://mediaplayerava.tiddlyhost.com/

For youtube annotations use {{||$:/bj/templates/media/gettemplate}}

The the fields yt-start and yt-end for youtube annotations have changed to starttime and endtime in order to use the same templates as the other players. If you have a lot of these to change I can provide instructions to bulk change them using tiddlyclip.

buggyj commented 1 year ago

you may want the tiddler annotationsOptions as well.

arunnbabu81 commented 1 year ago

I have now update the plugins, the plugin $:/plugins/bj/mediaplayerDynamicTmplates is also need, and now is uploaded to https://mediaplayerava.tiddlyhost.com/

Skiping of videos without playing is solved now.

For youtube annotations use {{||$:/bj/templates/media/gettemplate}}

I tried this template,but the annotation template is not seen in the video tiddlers for annotation. check this tiddler.

If you have a lot of these to change I can provide instructions to bulk change them using tiddlyclip.

Can you share that method. it will be useful.

you may want the tiddler annotationsOptions as well.

What is that for ?

buggyj commented 1 year ago

I have updated the plugins again. I have also put up a youtube annotations example. the tiddler annotationsOptions allows for variations of the templates - play with it to see what it does.

arunnbabu81 commented 1 year ago

The annotations doesn't seem to work in my wiki - Can you check in this demo wiki.

buggyj commented 1 year ago

I have fixed this now

arunnbabu81 commented 1 year ago

Thank you. It works now.

image

Is there any problem with the copy button ? What does it do ?

buggyj commented 1 year ago

The copy button copies the end time from one annotation to the beginning time of the next - it is useful for making adjustments to the times after a list of annotations has been created.

arunnbabu81 commented 1 year ago

The copy button copies the end time from one annotation to the beginning time of the next - it is useful for making adjustments to the times after a list of annotations has been created.

Is there an extra arrow in the copy button

buggyj commented 1 year ago

yes

arunnbabu81 commented 1 year ago

I cannot think of a way of doing this automatically unless this issue in tw is fixed: Jermolene/TiddlyWiki5#6699

Now that PR is merged, is it possible to do this

Is there any way to start playing the video from where we left in the last session ? Currently if I close the tiddler and reopen it at a latter time, the video restarts from the begining of that slice.