search

buggyrace / buggy-race-server

Race server and supporting material for running a "Buggy Racing" Python programming project
https://www.buggyrace.net
Other
1 stars 0 forks source link

Refactor Docker volumes/compose file #165

Open KuipersT opened 1 year ago

KuipersT commented 1 year ago

The docker-compose.yml and other files need to be refactored after the current RHUL deployment has ended.

Notably, the volume names should be refactored and it should be determined whether the node modules should really be persistent for security reasons.

davewhiteland commented 1 year ago

I suggest we rename both the directory inside the app and the volume that contains it to published-static-content so it's unambiguously clear what's in there. At the moment it's tech notes and task list (although #156 would add the editor repo zip file too).

An interesting consequence of this being a persistent volume is that it would allow the tech notes to be edited in place. That could be very helpful because at the moment they can't be customised (beyond the config settings that appear within them) and currently the remedy is to somehow (#135) extract them and self-host, which is non-trivial. As it happens there's already a IS_TECH_NOTE_PUBLISHING_ENABLED config setting that means an admin could prevent accidental overwriting of tech notes once they have been edited/customised in this way.