tests: update lab and have tests return a promise

buglabs / node-xml2json

Converts XML to JSON using node-expat

808 stars 209 forks source link

tests: update lab and have tests return a promise #159

Open scragg0x opened 6 years ago

scragg0x commented 6 years ago

Looks like joi only supports Node 8+. We have to do the same or downgrade joi. The spread operator is causing a test failure in older versions of Node.

https://github.com/hapijs/joi

KrzysztofTucholski commented 6 years ago

When do you think this could be merged?

Clement134 commented 6 years ago

What is missing for this PR to be merged ? All builds are failling because of global variable leaks :(

c4milo commented 6 years ago

It needs a rebase

Clement134 commented 6 years ago

@scragg0x the version of lab used in the package-lock is 15.4.4, could you update it at least to 15.5.0 in order to avoid warning about memory leaks with node 10 ?

Clement134 commented 5 years ago

Fixed in #166

p3x-robot commented 5 years ago

i am open to merge any pull request. I fixed it an named it as p3x-xml2json and it works with Nodejs 12.

https://github.com/patrikx3/xml2json