bugmark / bugmark_cl

Bugmark Command Line Client
0 stars 3 forks source link

contract resolve does not consider the status of a bug #52

Closed GeorgLink closed 6 years ago

GeorgLink commented 6 years ago

Regardless of whether I set the status of a bug to "closed" or "open", upon 'bmx contract resolve', the same position gets the payout.

How to repeat this issue? Run trivial bot and change the status of an issue (try both: closed and open) before resolving issues. The payout will always go to the same position holder, which is not the expected behavior.

andyl commented 6 years ago

I note the high priority - I'm on the road and will examine this evening.

Please if possible: add a failing regression test.

Also plz review enhancement request #53 which I think will help to give clarity about system behavior.

GeorgLink commented 6 years ago

Regression test added: #54

53 is an interesting idea, but less important to bot writing right now than:

andyl commented 6 years ago

Thanks for the PRs with the failing specs.

All CL specs now passing.

GeorgLink commented 6 years ago

Thank you! ​