Add a couple of missing usesService() calls

bugsnag / bugsnag-android-gradle-plugin

Gradle plugin for BugSnag which uploads ProGuard, DexGuard and NDK mapping files, and sends build notifications

https://docs.bugsnag.com/build-integrations/gradle/

MIT License

70 stars 38 forks source link

Add a couple of missing usesService() calls #487

Closed ZacSweers closed 1 year ago

ZacSweers commented 1 year ago

Goal

Noticed these while auditing plugins for the upcoming STABLE_CONFIGURATION_CACHE flag in Gradle. Consolidated logic in BugsnagFileUploadTask but let me know if you're rather keep that interface task-agnostic. Figured it was fair game since it used task annotations on its properties now

Design

Just matching the existing structure + consolidating some shared logic.

Changeset

Add missing usesService() calls to remaining tasks that use internal build services.

Testing

Existing tests

johnkiely1 commented 1 year ago

Hi @ZacSweers, thanks for this, we will look to get it reviewed and merged in asap.

lemnik commented 1 year ago

Hi @ZacSweers, thanks so much for this PR. I've moved the commit over PR #490 for CI reasons.

I'm going to close this PR and continue from there.

Thanks again.