bugsnag / bugsnag-android

BugSnag crash monitoring and reporting tool for Android apps
https://www.bugsnag.com/platforms/android/
Other
1.18k stars 205 forks source link

NDK should obey Configuration.maxBreadcrumbs #2020

Closed lemnik closed 4 months ago

lemnik commented 4 months ago

Goal

NDK should obey Configuration.maxBreadcrumbs

Design

Change the bugsnag_event.breadcrumbs to be dynamically allocated instead of a fixed-size block. This blob is written out to the event file after the core event, but before the feature-flags.

Changes

Testing

Manual testing, and a new end-to-end test added

bugsnagbot commented 4 months ago

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1845.12 1669.0
arm64_v8a 626.95 450.82
armeabi_v7a 561.42 385.29
x86 704.75 524.53
x86_64 671.99 495.86

Generated by :no_entry_sign: Danger