Don't redactKeys in OpaqueValues

bugsnag / bugsnag-android

BugSnag crash monitoring and reporting tool for Android apps

https://www.bugsnag.com/platforms/android/

Other

1.18k stars 205 forks source link

Don't redactKeys in OpaqueValues #2021

Closed lemnik closed 4 months ago

lemnik commented 4 months ago

Goal

Avoid redacting keys in the OpaqueValue class. The encoding used does not obey the configured set of redacted keys, and this behavior leads to some metadata being redacted in NDK crashes, while some is not.

Testing

Relied on existing tests.

bugsnagbot commented 4 months ago

Android notifier sizes

Format	Size impact of Bugsnag (kB)	Size impact of Bugsnag when Minified (kB)
APK	1845.2	1669.01
arm64_v8a	626.95	450.82
armeabi_v7a	561.42	385.29
x86	704.75	524.53
x86_64	671.99	495.86

Generated by :no_entry_sign: Danger