Include useful Activity.intent info in onCreate breadcrumbs - Githubissues

bugsnag / bugsnag-android

BugSnag crash monitoring and reporting tool for Android apps

https://www.bugsnag.com/platforms/android/

Other

1.18k stars 205 forks source link

Include useful Activity.intent info in onCreate breadcrumbs #2057

Closed lemnik closed 1 month ago

lemnik commented 2 months ago

Goal

Include some more Intent metadata in Activity.onCreate breadcrumbs to help debugging.

Design

When logging onCreate breadcrumbs we now selectively add the following to the breadcrumb metadata:

[Intent.action](https://developer.android.com/reference/android/content/Intent#getAction())
[Intent.categories](https://developer.android.com/reference/android/content/Intent#getCategories())
[Intent.type](https://developer.android.com/reference/android/content/Intent#getType())
[Intent.flags](https://developer.android.com/reference/android/content/Intent#getFlags())
[Intent.identifier](https://developer.android.com/reference/android/content/Intent#getIdentifier())
The keys of extras (no values are included)

We don't log the Intent.data as it would be too easy to leak sensitive data.

Testing

Manual testing

bugsnagbot commented 2 months ago

Android notifier sizes

Format	Size impact of Bugsnag (kB)	Size impact of Bugsnag when Minified (kB)
APK	1853.07	1674.82
arm64_v8a	631.04	450.82
armeabi_v7a	565.51	385.29
x86	708.85	528.62
x86_64	676.09	495.86

Generated by :no_entry_sign: Danger