search

bugsnag / bugsnag-android

BugSnag crash monitoring and reporting tool for Android apps
https://www.bugsnag.com/platforms/android/
Other
1.18k stars 205 forks source link

Handle cases when deserializing threads with no state #2058

Closed lemnik closed 1 month ago

lemnik commented 1 month ago

Goal

Handle extremely rare edge cases when deserializing reports (for OnSendCallback) where a thread.state property was not included.

Changeset

Replace the missing state with an empty string.

Testing

Introduced a new suite of unit tests to cover this edge case, and cases such as numeric & string thread IDs and extremely long thread IDs

bugsnagbot commented 1 month ago

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1853.13 1674.82
arm64_v8a 631.04 450.82
armeabi_v7a 565.51 385.29
x86 708.85 528.62
x86_64 676.09 495.86

Generated by :no_entry_sign: Danger