bugsnag / bugsnag-api-ruby

BugSnag API toolkit for Ruby
Other
21 stars 15 forks source link

Fix error handling as exceptions. #30

Closed askreet closed 3 years ago

askreet commented 3 years ago

Goal

The tests for errors as exceptions are failing on master. As far as I could tell in my own work, they simply don't work. The issue is Faraday's middleware base class uses respond_to?(:on_complete) to determine if the hook should be called, but it is declared as private, meaning that will always be false.

Design

N/A.

Changeset

Remove private specifier for the on_complete handler.

Testing

The existing tests pass now.

mattdyoung commented 3 years ago

Thanks for the PR! We'll look at reviewing / merging when we can.