github-actions[bot]
commented
6 months ago BugsnagPerformance.framework binary size increased by 19,392 bytes from 489,816 to 509,208
FILE SIZE VM SIZE
-------------- --------------
+49% +14.4Ki +49% +14.4Ki [__TEXT]
[ = ] 0 +783% +13.1Ki [__LINKEDIT]
+1.1% +1.77Ki +1.1% +1.77Ki String Table
+1.4% +1.16Ki +1.4% +1.16Ki Symbol Table
+0.9% +900 +0.9% +900 __TEXT,__text
+3.1% +336 +3.1% +336 __DATA,__objc_const
+3.2% +288 +3.2% +288 __TEXT,__objc_stubs
+2.6% +270 +2.6% +270 __TEXT,__objc_methname
+1.4% +136 +1.4% +136 __TEXT,__gcc_except_tab
+2.7% +64 +2.7% +64 __DATA,__objc_selrefs
+0.9% +36 +0.9% +36 __TEXT,__unwind_info
+0.5% +32 +0.5% +32 __DATA_CONST,__cfstring
+1.7% +16 +1.7% +16 Function Start Addresses
+0.3% +16 +0.3% +16 __TEXT,__cstring
+3.8% +8 +3.8% +8 __DATA,__objc_ivar
-0.8% -32 -0.8% -32 [__DATA_CONST]
-2.5% -408 -2.5% -408 [__DATA]
+4.0% +18.9Ki +6.7% +32.0Ki TOTALGenerated by :no_entry_sign: Danger
Goal
Adjust view load spans for pre-loaded views so they reflect the actual time it took to load the view.
Design
If the view is detected as pre-loaded on viewWillAppear, the span start time is adjusted and the view name is appended with "(pre-loaded)" suffix
Changeset
View load span adjustments on viewWillAppear Removed the viewWillDisappear fallback which was also causing very long spans that weren't necessarily even presented to the User