Fixed a crash on reportNetworkRequestSpan

bugsnag / bugsnag-cocoa-performance

Monitor the start-up, screen loading and network requests of your iOS app and see the results in your BugSnag dashboard.

https://docs.bugsnag.com/performance/integration-guides/ios

MIT License

11 stars 8 forks source link

Fixed a crash on reportNetworkRequestSpan #277

Closed robert-smartbear closed 2 weeks ago

robert-smartbear commented 3 weeks ago

Goal

Prevent a crash when User calls reportNetworkRequestSpan without setting networkRequestCallback on BugsnagPerformanceConfiguration

Changeset

Added a safeguard preventing a null being assigned to networkRequestCallback_ in BugsnagPerformanceImpl class

Testing

E2E tests

github-actions[bot] commented 3 weeks ago

BugsnagPerformance.framework binary size did not change - 459,640 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +24  +0.0%     +24    __TEXT,__text
  -0.1%     -24  -0.1%     -24    [__TEXT]
  [ = ]       0  [ = ]       0    TOTAL

Generated by :no_entry_sign: Danger