search

bugsnag / bugsnag-cocoa

BugSnag error monitoring & exception reporter for iOS, macOS, tvOS and watchOS
https://docs.bugsnag.com/platforms/ios
MIT License
234 stars 128 forks source link

Fix test flake for foregrounding breadcrumb #1659

Closed twometresteve closed 2 months ago

twometresteve commented 3 months ago

Goal

Fixes a test flake where we expect a breading for foregrounding the app.

Design

The test would flake heavily because it wasn't giving enough time for the foreground notification to arrive and be processed. This change introduces a new command where we can pause the processing of commands for a set period, giving the notifier time to receive and process the notification.

Testing

Covered by CI and I've run it >20 times locally without failing once.

github-actions[bot] commented 3 months ago

Bugsnag.framework binary size did not change - 718,176 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by :no_entry_sign: Danger