search

bugsnag / bugsnag-cocoa

BugSnag error monitoring & exception reporter for iOS, macOS, tvOS and watchOS
https://docs.bugsnag.com/platforms/ios
MIT License
234 stars 128 forks source link

Wait longer for the macOS test fixture to stop running #1662

Closed twometresteve closed 2 months ago

twometresteve commented 2 months ago

Goal

Attempt to reduce test flakes by waiting longer for crash reports to be written.

Design

I've noticed some test flakes recently where internal errors were being sent to Maze Runner due to invalid (truncated) crash report files. It seem that the lsappinfo mechanism we were using to detect the app stopping running was not reliably giving enough time for crash reports to be written, so I have fallen back to a simple wait instead.

Testing

Before this change, I could hardly get the RecrashObjcMachScenario to pass at all - after the change it passed 20/20 times. The down side of this change is that does increase the length of test runs from about 20 to 24 minutes.

github-actions[bot] commented 2 months ago

Bugsnag.framework binary size did not change - 718,176 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by :no_entry_sign: Danger