search

bugsnag / bugsnag-cocoa

BugSnag error monitoring & exception reporter for iOS, macOS, tvOS and watchOS
https://docs.bugsnag.com/platforms/ios
MIT License
234 stars 128 forks source link

[PLAT-12346] Remove inlined frame from the Bugsnag notify call chain entirely so t… #1667

Closed kstenerud closed 2 months ago

kstenerud commented 2 months ago

Goal

Remove the call to functions that are getting inlined so that we don't have to worry about the size of the bugsnag portion of the stack (which will change if the call gets inlined).

Note: Do not merge this yet. We will also be trying a different approach.

github-actions[bot] commented 2 months ago

Bugsnag.framework binary size decreased by 96 bytes from 718,312 to 718,216 :tada:

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.7%    +112  +0.7%    +112    [__TEXT]
  [ = ]       0  +3.7%     +96    [__LINKEDIT]
  +0.6%     +32  +0.3%     +32    [__DATA]
  +0.1%      +4  +0.1%      +4    __TEXT,__unwind_info
  -0.0%     -16  -0.0%     -16    String Table
  -0.7%     -32  -0.7%     -32    __DATA,__objc_selrefs
  -0.1%     -80  -0.1%     -80    Symbol Table
  -0.0%    -116  -0.0%    -116    __TEXT,__text
  -0.0%     -96  [ = ]       0    TOTAL

Generated by :no_entry_sign: Danger

kstenerud commented 2 months ago

Superseded by https://github.com/bugsnag/bugsnag-cocoa/pull/1668