search

bugsnag / bugsnag-expo

MIT License
11 stars 5 forks source link

Expo: Android: upload to bugsnag requires api key #114

Closed meabed closed 1 year ago

meabed commented 1 year ago

After the update, We get this error:

in fastlane step: send_build_to_bugsnag [12:40:16]: A Bugsnag API key is required to release a build. Set com.bugsnag.android.API_KEY in your AndroidManifest.xml to detect API key automatically.

it was working before the upgrade.

I think if this meta-info is need, it should be add by the plugin in the pre-build step instead of us doing it.

tomlongridge commented 1 year ago

Hi @meabed – which version were you updating from/to?

meabed commented 1 year ago

@tomlongridge latest version 5 with expo 48

tomlongridge commented 1 year ago

@meabed – I'm not sure what you mean by version 5? Was it a change in BugSnag library or Expo that seems to have caused the problem?

Also, if I understand you correctly, you're using Fastlane to publish an Expo app? Is that built with EAS?

meabed commented 1 year ago

@tomlongridge I think the new version of the plugin doesn't add the in android manifest correctly in Expo

johnkiely1 commented 1 year ago

Hi @meabed, as you will see we have made the code changes for reinstating the API key in the manifest and is just waiting to be released.

It is worth mentioning however the EAS plugin will upload source maps as part of the EAS build, so the Fastlane plugin may not be required for your builds unless you want to send additional metadata.

Out of interest it would be good to understand your build process a bit more if you are willing to share some details? How are you using Fastlane within the process of building your Expo app? Is that built with EAS?

johnkiely1 commented 1 year ago

The api key has now been reinstated in v48.1.0. Let us know if you have any further issues with it.