search

bugsnag / bugsnag-expo

MIT License
11 stars 5 forks source link

Android sourcemaps not uploaded #132

Closed krisgerhard closed 1 year ago

krisgerhard commented 1 year ago

Describe the bug

I'm using expo with @bugsnag/plugin-expo-eas-sourcemaps. After eas build iOS sourcemaps are uploaded but nothing about Android. Also bugsnag logs not present in EAS Build logs.

Environment

dubchoi commented 1 year ago

Also experiencing this

johnkiely1 commented 1 year ago

Hi @krisgerhard,

could you confirm which version of @bugsnag/plugin-expo-eas-sourcemaps you are using. Both your dependency on @bugsnag/expo and @bugsnag/plugin-expo-eas-sourcemaps should be set to 48.1.0.

Did you install BugSnag via the bugsnag-expo-cli or manually?

And could you confirm you are not using eas update?

krisgerhard commented 1 year ago

They are both 48.1.0. I initially used BugSnag without sourcemaps plugin, which I'm pretty sure I installed via cli (it is working as expected). Yesterday I manually added sourcemaps plugin and only got iOS sourcemaps using eas build.

yarn.lock

"@bugsnag/core@^7.16.0":
  version "7.19.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/core/-/core-7.19.0.tgz#7663a4addb1322e8315a4012dc9db2aad3fea53b"
  integrity sha512-2KGwdaLD9PhR7Wk7xPi3jGuGsKTatc/28U4TOZIDU3CgC2QhGjubwiXSECel5gwxhZ3jACKcMKSV2ovHhv1NrA==
  dependencies:
    "@bugsnag/cuid" "^3.0.0"
    "@bugsnag/safe-json-stringify" "^6.0.0"
    error-stack-parser "^2.0.3"
    iserror "0.0.2"
    stack-generator "^2.0.3"

"@bugsnag/cuid@^3.0.0":
  version "3.0.2"
  resolved "https://registry.yarnpkg.com/@bugsnag/cuid/-/cuid-3.0.2.tgz#544f8e6e7e3768c8cb618ca5c5fb1eea6aacbb7e"
  integrity sha512-cIwzC93r3PQ/INeuwtZwkZIG2K8WWN0rRLZQhu+mr48Ay+i6sEki4GYfTsflse7hZ1BeDWrNb/Q9vgY3B31xHQ==

"@bugsnag/delivery-expo@^48.0.0":
  version "48.0.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/delivery-expo/-/delivery-expo-48.0.0.tgz#27235b570cf4c1e7e3d6f357da26c56a1e338f09"
  integrity sha512-om9DsOY6lPJJEfO/2dqxe/x++ukqV6leKmSS128XB/WtXDRA3at2md5VXXUYwm3tHDG89/ktAv/LkBEHlUcaMw==

"@bugsnag/expo@^48.1.0":
  version "48.1.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/expo/-/expo-48.1.0.tgz#715ac54110ba5dc9f0000eba61edabca6eb5d33f"
  integrity sha512-J6kvGzdZjY8tED6EvayiDTlP4LLpDYmfyt3chok3oB+kdalqrUgXAB7bIWLEyRSdPFIJWpwMqfUnVWwlEEJ7qg==
  dependencies:
    "@bugsnag/core" "^7.16.0"
    "@bugsnag/delivery-expo" "^48.0.0"
    "@bugsnag/plugin-browser-session" "^7.16.0"
    "@bugsnag/plugin-console-breadcrumbs" "^7.16.0"
    "@bugsnag/plugin-expo-app" "^48.0.0"
    "@bugsnag/plugin-expo-app-state-breadcrumbs" "^48.0.0"
    "@bugsnag/plugin-expo-connectivity-breadcrumbs" "^48.0.0"
    "@bugsnag/plugin-expo-device" "^48.1.0"
    "@bugsnag/plugin-network-breadcrumbs" "^7.16.0"
    "@bugsnag/plugin-react" "^7.16.0"
    "@bugsnag/plugin-react-native-global-error-handler" "^7.16.0"
    "@bugsnag/plugin-react-native-orientation-breadcrumbs" "^7.16.0"
    "@bugsnag/plugin-react-native-unhandled-rejection" "^7.16.0"
    "@bugsnag/source-maps" "^2.3.0"
    bugsnag-build-reporter "^1.0.1"

"@bugsnag/plugin-browser-session@^7.16.0":
  version "7.19.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-browser-session/-/plugin-browser-session-7.19.0.tgz#b2603b0e53637ed283238a3c7838b1f5b96d1060"
  integrity sha512-AdgKF9lnavWFSOVbldrTfE59vorcfUlxECorHucjZ5/Az9ctJxDWC1HceAT+diEMcdFgVmivKiiqegEcyCsDdw==

"@bugsnag/plugin-console-breadcrumbs@^7.16.0":
  version "7.19.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-console-breadcrumbs/-/plugin-console-breadcrumbs-7.19.0.tgz#89773558865f9ee4aa633408f7ab56a741e7b553"
  integrity sha512-ZHqPAK0WpbvWjj2wwSV8+C8+K9TOyQsfZnRJ7lIadbeUUJORmFRnG0vUHKBvwxMP7bqCj8fOe/S0kKF3dfMMKA==

"@bugsnag/plugin-expo-app-state-breadcrumbs@^48.0.0":
  version "48.0.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-expo-app-state-breadcrumbs/-/plugin-expo-app-state-breadcrumbs-48.0.0.tgz#911be6caea4165f0228b4fdffae614bfc531fadc"
  integrity sha512-AQnLdPmf+UwNnlwLodwS1vNSP8JzEC+YdKLMQOAVPV1pRth25ku+xsIgi82YV2/1jLZlgznoLMgOxUAVUWUQDg==

"@bugsnag/plugin-expo-app@^48.0.0":
  version "48.0.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-expo-app/-/plugin-expo-app-48.0.0.tgz#69e45415d25a2bd29017f44f021e4d108065ab00"
  integrity sha512-NWCTMxQCqirmbjoMQFfqNp9uK1vuDlzklweElNsuKau0XdjY2EiP5q9mKrYH7alTGM2EDVPHcCvnhsQPPer05w==

"@bugsnag/plugin-expo-connectivity-breadcrumbs@^48.0.0":
  version "48.0.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-expo-connectivity-breadcrumbs/-/plugin-expo-connectivity-breadcrumbs-48.0.0.tgz#a738d23c4e056e492cc798816636108589028c11"
  integrity sha512-TO71fw50gGYIs+564NQUOJKy9dmgik9g/K9TZU9mfh1F2FV98oVt+ERc+TllqvOFr4/zhNgNz3JR3GCzXET3vw==

"@bugsnag/plugin-expo-device@^48.1.0":
  version "48.1.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-expo-device/-/plugin-expo-device-48.1.0.tgz#f3f4b369f1bac6d6b870c99025428f680efbb67f"
  integrity sha512-SnLXEpDLXOlURWs0EEOZDXzjPBx7AnXA0JB6sdMa7tTE//Ek3S8by5PWPMtBt19Bo9mC3wkkz3P7nAPANrUMKg==

"@bugsnag/plugin-expo-eas-sourcemaps@^48.1.0":
  version "48.1.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-expo-eas-sourcemaps/-/plugin-expo-eas-sourcemaps-48.1.0.tgz#8cda1a1171ce380f5c8dc275376443aa564cfc93"
  integrity sha512-dKBy1NZvcVLzRXR3/nNJEFOEsUl7vlfTggJGxyCnXv8wkd+NYxBJvy9rL41RdJ+AhJ3FDpyg73hJ8DsyPwEa+Q==

"@bugsnag/plugin-network-breadcrumbs@^7.16.0":
  version "7.19.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-network-breadcrumbs/-/plugin-network-breadcrumbs-7.19.0.tgz#eb1cca507d6181e09e1b81a0780bfda1d1435fe2"
  integrity sha512-Farc0XuUoxv10kJE65zfgZlqujR7TDu8QjwxA4YDxEE41kFM8TAw0CAK15WkQK1UTsNACiiAETZGyU279eB65Q==

"@bugsnag/plugin-react-native-global-error-handler@^7.16.0":
  version "7.19.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-react-native-global-error-handler/-/plugin-react-native-global-error-handler-7.19.0.tgz#cbf92d3b782bdc347b06ea2dcb9cbab2c22439df"
  integrity sha512-zf+KIHqGEAs2ekAzJCTS0rM1nKrmpIfznBhn72xZJwyfYrh0wbvjZjClDEwxDZ24uNVUUHrIymzdqxpHqVb0lg==

"@bugsnag/plugin-react-native-orientation-breadcrumbs@^7.16.0":
  version "7.19.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-react-native-orientation-breadcrumbs/-/plugin-react-native-orientation-breadcrumbs-7.19.0.tgz#6657105b2f1c8e7f5b3b6a3951ac865026d25842"
  integrity sha512-CvICiyKr5nSiKXtF7acyVGM/1BqX7BDP2FOCtmuJxKFYjfiVOtCFAQXk4jnPJG+UEZvY+vtoRlR2EnLhXDdTRA==

"@bugsnag/plugin-react-native-unhandled-rejection@^7.16.0":
  version "7.19.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-react-native-unhandled-rejection/-/plugin-react-native-unhandled-rejection-7.19.0.tgz#729adda2da1f3483de0195c6f5aee2fd59185b6e"
  integrity sha512-+XDk0OoeM6MZhBh7kEalbRwFuhCZST6Y1jOostfz0fhrmT4FdgQYi1FWcPNsUTcjqv7M48pOFZNx8yWI0lGaYg==

"@bugsnag/plugin-react-navigation@^7.19.0":
  version "7.19.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-react-navigation/-/plugin-react-navigation-7.19.0.tgz#3cb4fc4e8474849a946f64eeffcd3f1d7fc7073f"
  integrity sha512-cDuHwykruivUZFtaIt5/MhbfRyH20X0XFrW071V+5M+rXAnpJa2AwppXwEuP7DWeER38hd2O8VqaUU2Ijes2Lw==

"@bugsnag/plugin-react@^7.16.0":
  version "7.19.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/plugin-react/-/plugin-react-7.19.0.tgz#3f86c6ed2745cd60a4099d0e14ca46f2b9cf501f"
  integrity sha512-owC4QXYJWGllMoOPcH5P7sbDIDuFLMCbjGAU6FwH5mBMObSQo+1ViSKImlTJQUFXATM8ySISTBVt7w3C6FFHng==

"@bugsnag/safe-json-stringify@^6.0.0":
  version "6.0.0"
  resolved "https://registry.yarnpkg.com/@bugsnag/safe-json-stringify/-/safe-json-stringify-6.0.0.tgz#22abdcd83e008c369902976730c34c150148a758"
  integrity sha512-htzFO1Zc57S8kgdRK9mLcPVTW1BY2ijfH7Dk2CeZmspTWKdKqSo1iwmqrq2WtRjFlo8aRZYgLX0wFrDXF/9DLA==

"@bugsnag/source-maps@^2.3.0", "@bugsnag/source-maps@^2.3.1":
  version "2.3.1"
  resolved "https://registry.yarnpkg.com/@bugsnag/source-maps/-/source-maps-2.3.1.tgz#3caa33b7b9879e58e233eae017726852c50b1106"
  integrity sha512-9xJTcf5+W7+y1fQBftSOste/3ORi+d5EeCCMdvaHSX69MKQP0lrDiSYpLwX/ErcXrTbvu7nimGGKJP2vBdF7zQ==
  dependencies:
    command-line-args "^5.1.1"
    command-line-usage "^6.1.0"
    concat-stream "^2.0.0"
    consola "^2.15.0"
    form-data "^3.0.0"
    glob "^7.1.6"
    read-pkg-up "^7.0.1"
johnkiely1 commented 1 year ago

Thanks, in that case would you mind sharing your app.json or app.config.js file where you have configured the sourcemap plugin. It may also be helpful to know which Bugsnag organisation/project you are expecting these uploads to apply to. You can send us that information via a quick email to support@bugsnag.com and reference this issue URL.

johnkiely1 commented 1 year ago

Additionally if you could include any eas build logs you're happy to share it might help us narrow down what is happening.

krisgerhard commented 1 year ago

@johnkiely1 Can you copy what we should see in Android eas build log? Because at the moment there is nothing with "bugsnag". In iOS build I see bugsnag logs and AS I said sourvemaps are also succesfully uoloaded there.

johnkiely1 commented 1 year ago

The upload should use the code here: https://github.com/bugsnag/bugsnag-expo/blob/v48/next/packages/plugin-expo-eas-sourcemaps/lib/eas-build-on-success.js. This should give you an idea of the log messages we might expect to see in the build log.

krisgerhard commented 1 year ago

I managed to solve it. https://docs.bugsnag.com/platforms/react-native/expo/manual-setup/#eas-build is missing instructions for package.json.

Your have to add on-success hook.

  "scripts": {
     ...
    "eas-build-on-success": "npx bugsnag-eas-build-on-success"
  }
johnkiely1 commented 1 year ago

Ah that's good news, Yeah looks like we missed that update in our manual installation docs as it is a new additional requirement when using expo v48. The cli does add it automatically. Thanks for spotting this and we will get our docs updated asap.

johnkiely1 commented 1 year ago

Hi @krisgerhard, just to let you know the docs have now been updated. Thanks again.

krisgerhard commented 1 year ago

Thank you for such fast response!